WiFiSecureClient fixes and improvements #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SHA1 fingerprint is broken now: more info: https://shattered.io
When occur an error in WiFiClientSecure library just return the error message and clean the context avoiding crash - fix for #211 Translate MbedTLS error codes in messages for best understanding
mbedtls_pk_parse_key needs a const unsigned char * certificate. In old implementation the certificate was declarated as char * so first it converts to unsigned and after to const. When we convert signed to unsigned it may result in a +1 larger output. Fix issue #223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Best MbedTLS error handling, returning the error code and translate it to a error message.
-Fix for the issue #223
-Partial fix for the issue #211 (avoid crashing, just return mbedtls error and close the connection), but still don't close in described situation.
-Add CA certificate in example, because SHA1 fingerprint is broken now, details in https://shattered.io/